Colorize unstable callsites #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 83.56% 83.24% -0.33%
==========================================
Files 7 7
Lines 931 949 +18
==========================================
+ Hits 778 790 +12
- Misses 153 159 +6
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/unstable_callsites
branch
from
c535722
to
8597e87
Compare
|
I don't know why this wasn't passing yesterday, but I was developing it on a not-up-to-date branch. Either a rebase fixed the problem (quite possible since the error was in "codeview" tests which changed since I branched) or there could be something flaky happening. |
|
Any concerns here? No urgency, but the odd issues seem to have been fixed. |
|
No concerns! LGTM!
…On Fri, Aug 6, 2021, 19:12 Tim Holy ***@***.***> wrote:
Any concerns here? No urgency, but the odd issues seem to have been fixed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDO2TDIOT4DF4VAXQI66DT3QJZFANCNFSM5BTU6I3Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 (see the red
%symbols below)