Add x86 runners to CI #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude mac as x86 mac is tier 3 for Julia
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 9
Lines 1551 1551
======================================
Misses 1551 1551 ☔ View full report in Codecov by Sentry. |
Choice on using Int64 or adapting tests to Int were based on smallness of change.
Zentrik
changed the title
Got it working locally.
|
I believe the nightly failures are due to JuliaLang/julia#52796. |
|
Pretty sure the other failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like #524 probably has existed for a long time, having CI would probably be helpful then.