Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only do the getfield optimization when it is safe #120

Merged
merged 1 commit into from Mar 7, 2019
Merged

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 7, 2019

Fixes #119

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #120   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           9      9           
  Lines        1440   1441    +1     
=====================================
- Misses       1440   1441    +1
Impacted Files Coverage Δ
src/JuliaInterpreter.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b0efd...3566a9d. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants