Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP add a test for @interpret^2 #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP add a test for @interpret^2 #252

wants to merge 2 commits into from

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 31, 2019

Closes #228

@KristofferC
Copy link
Member Author

Actually:

julia> JuliaInterpreter.disable_recycle[] = true
true

julia> f() = @interpret sin(2.0)
f (generic function with 1 method)

julia> f()
0.9092974268256817

julia> @interpret f()
1.0

@codecov-io
Copy link

Codecov Report

Merging #252 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   87.15%   87.21%   +0.05%     
==========================================
  Files          14       14              
  Lines        1985     1986       +1     
==========================================
+ Hits         1730     1732       +2     
+ Misses        255      254       -1
Impacted Files Coverage Δ
src/construct.jl 92.21% <100%> (+0.03%) ⬆️
src/interpret.jl 86.68% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deef44...5a22f34. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #252 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   87.15%   87.21%   +0.05%     
==========================================
  Files          14       14              
  Lines        1985     1986       +1     
==========================================
+ Hits         1730     1732       +2     
+ Misses        255      254       -1
Impacted Files Coverage Δ
src/construct.jl 92.21% <100%> (+0.03%) ⬆️
src/interpret.jl 86.68% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7deef44...5a22f34. Read the comment docs.

@KristofferC KristofferC changed the title add a test for @interpret^2 WIP add a test for @interpret^2 Mar 31, 2019
@timholy
Copy link
Member

timholy commented Mar 31, 2019

I'd rather have a clear understanding of what steps in logic fail under these circumstances. (Maybe you do, but I don't.)

@KristofferC
Copy link
Member Author

Hence WIP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants