Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choice of AD backend for conditions #80

Closed
wants to merge 1 commit into from
Closed

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jul 30, 2023

Fixes #69

At the moment this works with default/adaptive backend and with ForwardDiffBackend() but not with ZygoteBackend(). I suspect this might be a bug in AbstractDifferentiation.jl (maybe AD#63). @mohamed82008 could you take a look? I skipped the problematic tests in test/systematic.jl and marked them with TODO.

@thorek1 wanna take this branch out for a spin and see if it solves your problem?

This PR also changes the constructor syntax in a breaking way: f and c are positional arguments, along with HandleByproduct(), but linear_solver becomes a kwarg along with the new conditions_backend

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: -0.23% ⚠️

Comparison is base (5990573) 91.83% compared to head (450a63c) 91.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   91.83%   91.60%   -0.23%     
==========================================
  Files           9        9              
  Lines         147      143       -4     
==========================================
- Hits          135      131       -4     
  Misses         12       12              
Files Changed Coverage Δ
src/ImplicitDifferentiation.jl 66.66% <ø> (ø)
src/conditions.jl 71.42% <66.66%> (ø)
ext/ImplicitDifferentiationChainRulesExt.jl 100.00% <100.00%> (ø)
ext/ImplicitDifferentiationForwardDiffExt.jl 100.00% <100.00%> (ø)
src/implicit_function.jl 84.21% <100.00%> (-3.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Member Author

gdalle commented Aug 4, 2023

Closing because this is completely outdated due to #86

@gdalle gdalle closed this Aug 4, 2023
@gdalle gdalle deleted the conditions_backend branch August 4, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse mode AD with forward mode backend for conditions (and vice versa)
1 participant