Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests to diagnose Frank-Wolfe linear solver error #39

Merged
merged 7 commits into from
Mar 28, 2023
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Feb 28, 2023

  • Revert specification of test dependencies to the more robust version (see this issue)
  • Adjust default parameters for Frank-Wolfe (increase precision and switch step size selection) because a recent release or FrankWolfe.jl broke our tests (see Adaptive line search for Frank-Wolfe breaks tests #40)
  • Deactivate test verbosity to make CI logs easier to read
  • Switch data to Float32 to suppress Flux.jl warning
  • Try to parallelize tests but they no longer show up in the test set so I gave up (see this discourse thread, it seems like an open problem)

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.27 ⚠️

Comparison is base (49dfd06) 89.26% compared to head (a840f89) 89.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   89.26%   89.00%   -0.27%     
==========================================
  Files          18       18              
  Lines         382      382              
==========================================
- Hits          341      340       -1     
- Misses         41       42       +1     
Impacted Files Coverage Δ
src/frank_wolfe/frank_wolfe_utils.jl 83.33% <ø> (ø)
src/frank_wolfe/differentiable_frank_wolfe.jl 93.75% <25.00%> (-6.25%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdalle gdalle requested a review from BatyLeo February 28, 2023 23:01
test/argmax.jl Outdated Show resolved Hide resolved
test/argmax.jl Outdated Show resolved Hide resolved
test/argmax.jl Outdated Show resolved Hide resolved
test/argmax.jl Outdated Show resolved Hide resolved
test/paths.jl Outdated Show resolved Hide resolved
test/paths.jl Outdated Show resolved Hide resolved
test/ranking.jl Outdated Show resolved Hide resolved
test/ranking.jl Outdated Show resolved Hide resolved
test/ranking.jl Outdated Show resolved Hide resolved
test/ranking.jl Outdated Show resolved Hide resolved
@gdalle
Copy link
Member Author

gdalle commented Mar 1, 2023

@BatyLeo maybe switching to agnostic step size is not a good idea, see ZIB-IOL/FrankWolfe.jl#387 (comment)

Let's wait a bit before we merge

@BatyLeo
Copy link
Member

BatyLeo commented Mar 1, 2023

@BatyLeo maybe switching to agnostic step size is not a good idea, see ZIB-IOL/FrankWolfe.jl#387 (comment)

Let's wait a bit before we merge

Ok 👍

@BatyLeo BatyLeo merged commit 72e54d6 into main Mar 28, 2023
@BatyLeo BatyLeo deleted the fix_ci branch March 28, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants