-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tests to diagnose Frank-Wolfe linear solver error #39
Conversation
gdalle
commented
Feb 28, 2023
•
edited
edited
- Revert specification of test dependencies to the more robust version (see this issue)
- Adjust default parameters for Frank-Wolfe (increase precision and switch step size selection) because a recent release or FrankWolfe.jl broke our tests (see Adaptive line search for Frank-Wolfe breaks tests #40)
- Deactivate test verbosity to make CI logs easier to read
- Switch data to Float32 to suppress Flux.jl warning
- Try to parallelize tests but they no longer show up in the test set so I gave up (see this discourse thread, it seems like an open problem)
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 89.26% 89.00% -0.27%
==========================================
Files 18 18
Lines 382 382
==========================================
- Hits 341 340 -1
- Misses 41 42 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@BatyLeo maybe switching to agnostic step size is not a good idea, see ZIB-IOL/FrankWolfe.jl#387 (comment) Let's wait a bit before we merge |
Ok 👍 |