Improvements to pullback_function #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 79.53% 78.26% -1.28%
==========================================
Files 1 1
Lines 342 345 +3
==========================================
- Hits 272 270 -2
- Misses 70 75 +5
Continue to review full report at Codecov.
|
|
Thanks @sethaxen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few improvements to
pullback_functionwhile resolving #17:UniformScalingandAbstractMatrixto their own utility function_dot, with checks for necessary conditions_dotand usegradientso we don't need toadjoint, which will be faster when there's a faster version ofgradientavailable.