Don't mutate cotangent in rule for exp (#588)

* Don't mutate input cotangent

* Increment patch number

* Add test for not mutating if cotangent is adjoint

Project.toml

@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "1.26"
+version = "1.26.1"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/rulesets/LinearAlgebra/matfun.jl

@@ -132,7 +132,7 @@ function rrule(::typeof(exp), A0::StridedMatrix{<:BlasFloat})
             # Ensures ∂X is mutable. The outer `adjoint` is unwrapped without copy by
             # the default _matfun_frechet_adjoint!
             ΔX = unthunk(X̄)
-            ∂X = ChainRulesCore.is_inplaceable_destination(ΔX) ? ΔX : convert(Matrix, ΔX')'
+            ∂X = ChainRulesCore.is_inplaceable_destination(ΔX) ? copy(ΔX) : convert(Matrix, ΔX')'
             ∂A = _matfun_frechet_adjoint!(exp, ∂X, A, X, intermediates)
             return NoTangent(), ∂A
         end

test/rulesets/LinearAlgebra/matfun.jl

@@ -35,6 +35,15 @@
             Y, back = rrule(exp, A)
             @maybe_inferred back(rand_tangent(Y))
         end
+        @testset "cotangent not mutated" begin
+            # https://github.com/JuliaDiff/ChainRules.jl/issues/512
+            A = [1.0 2.0; 3.0 4.0]
+            Y, back = rrule(exp, A)
+            ΔY′ = rand_tangent(Y)'
+            ΔY′copy = copy(ΔY′)
+            back(ΔY′)
+            @test ΔY′ == ΔY′copy
+        end
         @testset "imbalanced A" begin
             A = Float64[0 10 0 0; -1 0 0 0; 0 0 0 0; -2 0 0 0]
             test_rrule(exp, A; check_inferred=false)