remove _subtract!!

JuliaDiff · Oct 15, 2020 · d9461cd · d9461cd
1 parent 03688d2
commit d9461cd
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 32 deletions.
diff --git a/src/rulesets/Base/arraymath.jl b/src/rulesets/Base/arraymath.jl
@@ -111,7 +111,7 @@ end
 
 function rrule(::typeof(-), x::AbstractArray)
     function negation_pullback(ȳ)
-        return NO_FIELDS, InplaceableThunk(@thunk(-ȳ), ā -> _subtract!!(ā, ȳ))
+        return NO_FIELDS, InplaceableThunk(@thunk(-ȳ), ā -> ā .-= ȳ)
     end
     return -x, negation_pullback
 end
diff --git a/src/rulesets/LinearAlgebra/utils.jl b/src/rulesets/LinearAlgebra/utils.jl
@@ -17,9 +17,6 @@ _mulsubtrans!!(X::AbstractZero, F::AbstractZero) = X
 _mulsubtrans!!(X::AbstractZero, F::AbstractMatrix{<:Real}) = X
 _mulsubtrans!!(X::AbstractMatrix{<:Real}, F::AbstractZero) = F
 
-_subtract!!(x, y) = x - y
-_subtract!!(x::Array, y::AbstractArray) = x .-= y
-
 # I - X, overwrites X
 function _eyesubx!(X::AbstractMatrix)
     n, m = size(X)

diff --git a/test/rulesets/LinearAlgebra/utils.jl b/test/rulesets/LinearAlgebra/utils.jl
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -40,7 +40,6 @@ println("Testing ChainRules.jl")
             include(joinpath("rulesets", "LinearAlgebra", "structured.jl"))
             include(joinpath("rulesets", "LinearAlgebra", "factorization.jl"))
             include(joinpath("rulesets", "LinearAlgebra", "blas.jl"))
-            include(joinpath("rulesets", "LinearAlgebra", "utils.jl"))
         end
 
         print(" ")