New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logdet too general #244

Closed

willtebbutt opened this issue Aug 17, 2020 · 0 comments · Fixed by #245

Member

willtebbutt commented Aug 17, 2020

Our logdet implementation is too general. In particular, it captures any and all AbstractMatrixs, which is bad for the reasons discussed in #232 .

We should at the very least constrain it to be for StridedMatrix{<:Real}s.

The text was updated successfully, but these errors were encountered:

willtebbutt linked a pull request

that will close this issue

Restrict types in logdet #245

Merged

willtebbutt closed this as completed in #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment