Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict types in logdet #245

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Restrict types in logdet #245

merged 2 commits into from
Aug 17, 2020

Conversation

willtebbutt
Copy link
Member

Fixing this makes e.g.Zygote "just work" withMvNormal and GenericMvT in Distributions by preventing ChainRules from taking control of the way that AbstractPDMats compute logdet.

@willtebbutt
Copy link
Member Author

Zygote integration failure is unrelated to this change.

@willtebbutt willtebbutt added the bug Something isn't working label Aug 17, 2020
@willtebbutt willtebbutt linked an issue Aug 17, 2020 that may be closed by this pull request
logdet too general #244
Closed
@oxinabox
Copy link
Member

Not a fan of the existance of StridedMatrix
Would rather if we could just say Matrix,
but we can't so approving it

@willtebbutt willtebbutt merged commit d55540a into master Aug 17, 2020
@willtebbutt willtebbutt deleted the wct/fix-logdet branch August 17, 2020 13:21
This was referenced May 7, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logdet too general
2 participants
@willtebbutt @oxinabox