Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do using of at-required packages relative #116

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Oct 4, 2019

I believe this should solve #115

From the Requires.jl readme:

In the @require block, or any included files, you can use or import the package, but note that you must use the syntax using .Gadfly or import .Gadfly, rather than the usual syntax. Otherwise you will get a warning about Gadfly not being in dependencies.

@nickrobinson251
Copy link
Contributor

Have you verified this works (locally)?

@oxinabox
Copy link
Member Author

oxinabox commented Oct 4, 2019

It does not.
I think I need an extra .

@oxinabox
Copy link
Member Author

oxinabox commented Oct 4, 2019

verified properly: it doesn't give that warning anymore.
And also it doesn't just error.

Copy link
Contributor

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once verified locally and CI passes, go ahead and merge

@oxinabox oxinabox merged commit 296723c into master Oct 4, 2019
@oxinabox oxinabox deleted the ox/requiresright branch August 17, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants