Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow sum of anything in rrule #124

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Don't allow sum of anything in rrule #124

merged 2 commits into from
Oct 28, 2019

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Oct 18, 2019

Can't do this right without JuliaDiff/ChainRulesCore.jl#8
because tuples are not differentials as they do not support addition.

So we restict to the case for rrule where it will be an array.

@oxinabox oxinabox merged commit f17dcdc into master Oct 28, 2019
@nickrobinson251 nickrobinson251 deleted the ox/notuple branch October 28, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants