Update to ChainRulesCore 0.5.1 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, accidentally removed fdm test
YingboMa
force-pushed
the
myb/fuse_frule
branch
from
602537b
to
d393d12
Compare
|
Maybe point this PR at Lyndon's branch? #145 |
|
Waiting for JuliaDiff/ChainRulesCore.jl#90 |
oxinabox
approved these changes
Jan 12, 2020
src/rulesets/LinearAlgebra/blas.jl
Outdated
| end | ||
| return BLAS.asum(x), asum_pushforward | ||
| function frule(::typeof(BLAS.asum), x, _, Δx) | ||
| return BLAS.asum(x), sum(cast(sign, x) * Δx) |
There was a problem hiding this comment.
Suggested change
| return BLAS.asum(x), sum(cast(sign, x) * Δx) | |
| return BLAS.asum(x), sum(sign(x) .* Δx) |
There was a problem hiding this comment.
There is actually no BLAS.asum(x), so I removed it.
There was a problem hiding this comment.
Fair enough, wonder how it got in there,
There was a problem hiding this comment.
Ah, I confused myself. BLAS.asum(x) is there, but it is not documented in Julia
help?> BLAS.asum
asum(n, X, incx)
Sum of the absolute values of the first n elements of array X with stride incx.
Examples
≡≡≡≡≡≡≡≡≡≡
julia> BLAS.asum(5, fill(1.0im, 10), 2)
5.0
julia> BLAS.asum(2, fill(1.0im, 10), 5)
2.0
oxinabox
approved these changes
Jan 12, 2020
This reverts commit 3fe59b4.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.