Remove store!, accumulate, accumulate!
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jan 22, 2020
nickrobinson251
force-pushed
the
npr/rm-accumulate
branch
from
25b17dd
to
79d4393
Compare
nickrobinson251
added a commit
that referenced
this pull request
Jan 22, 2020
* Remove `store!`, `accumulate`, `accumulate!` * Remove `test_accumulate` functions
nickrobinson251
added a commit
that referenced
this pull request
Jan 22, 2020
* Remove `store!`, `accumulate`, `accumulate!` * Remove `test_accumulate` functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accumulateand friends ChainRulesCore.jl#110 (xref Bring backstore!,accumulate, andaccumulate!? ChainRulesCore.jl#113)Composite#157 as that did half the work already (so might want to merge that first, then re-point this PR at master)