Update to new API #169
Update to new API #169
Conversation
There was a problem hiding this comment.
Tests pass on this branch if I add the corresponding branches
(ChainRules) pkg> add ChainRulesTestUtils#wct/frule-api-fix
(ChainRules) pkg> add ChainRulesCore#wct/frule-api-fixso seems good to me, once the other PRs are merged and tagged and the compat here updated
Co-Authored-By: Nick Robinson <npr251@gmail.com>
Co-Authored-By: Nick Robinson <npr251@gmail.com>
Co-Authored-By: Nick Robinson <npr251@gmail.com>
…nRules.jl into wct/frule-api-fix
|
@nickrobinson251 let me know if you're happy for this to be merged now. |
.travis.yml
Outdated
| @@ -10,7 +10,6 @@ julia: | |||
| - nightly | |||
There was a problem hiding this comment.
| - nightly | |
| - 1.4 |
Yeah. This is what caused this slip up with the API in the first place -- we simply didn't have the range of things implemented to catch the problem. I think that the right place to resolve this issue is the core though -- I've implemented extra tests to prevent API regression, but presumably there are other things we're not handling properly (kwargs, for example). |
|
@oxinabox @nickrobinson251 anyone able to reproduce the errors locally? Tests are passing for me on 1.3.1. Have checked versions, and I appear to be using the same as CI is using... |
|
Oh is this: #149 ? I think we had travis disabled on 1.3 for reasons because it was just broken even though it worked fine in 1.3 on everyones local machines |
|
Ahh I see. Will re-disable and merge once tests pass. |
See ChainRulesCore for related PR