Fix errors revealed by Zygote's tests #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems unlikely. Note this issue on FiniteDifferences. This PR aims to fix it. |
|
Ok this is ready for review though it needs the fix in TestUtils before tests will run |
|
Once we have JuliaDiff/ChainRulesTestUtils.jl#25 |
nickrobinson251
approved these changes
Apr 27, 2020
nickrobinson251
approved these changes
Apr 28, 2020
| # TODO: Assert about the primal type in the Composite, It should be Diagonal | ||
| # infact it should be exactly the type of `Diagonal(d)` | ||
| # but right now Zygote loses primal type information so we can't use it. | ||
| # See https://github.com/FluxML/Zygote.jl/issues/603 |
There was a problem hiding this comment.
i am confused by this: how do we end up with a Composite but not a Composite{P} for the correct P?
There was a problem hiding this comment.
Because in the Zygote PR we turn all NamedTuples into Composite{Any}
|
Cross referencing this -- I'm not sure why |
Co-Authored-By: Nick Robinson <npr251@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these because of Zygote's tests
while working on FluxML/Zygote.jl#366
It is hard to add tests for them because they are about testing that
we didn't define a rule we should not have,
and that we don't thunk to many times