Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global random number generator #181

Merged
merged 2 commits into from
May 1, 2020
Merged

Use global random number generator #181

merged 2 commits into from
May 1, 2020

Conversation

mattBrzezinski
Copy link
Member

Resolves: #180

From the Test documentation for @testset:

Before the execution of the body of a @testset, there is an implicit call to Random.seed!(seed) where seed is the current seed of the global RNG.

So we do not need to manually seed our @testsets.

oxinabox
oxinabox reviewed Apr 29, 2020
View reviewed changes
Project.toml Show resolved Hide resolved
oxinabox
oxinabox approved these changes Apr 29, 2020
View reviewed changes
test/rulesets/Base/array.jl Show resolved Hide resolved
@mattBrzezinski
Copy link
Member Author

Just going to wait until JuliaDiff/ChainRulesTestUtils.jl#27 goes in, then I'll make the change to call the new function and we should be good to go!

@mattBrzezinski mattBrzezinski merged commit 236134f into master May 1, 2020
@oxinabox oxinabox deleted the MB/rng branch August 17, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean out all of the local random number generators from the test
3 participants
@mattBrzezinski @oxinabox @nickrobinson251