Extend Base.isapprox instead of defining cr_isapprox #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the testing utilities we define an internal `cr_isapprox` function that mimics `isapprox` except we only accept a subset of the keyword arguments accepted by `isapprox`. Instead, we can just define methods for `isapprox` on ChainRules-defined types for the purposes of testing. That way we can more easily take arbitrary keyword arguments and get Test's special-cased pretty printing for `@test a ≈ b`.
|
Coverage change is bogus; I didn't touch anything in |
willtebbutt
approved these changes
Apr 29, 2019
|
Well we can always revert if we find that this wrecks things horribly 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the testing utilities we define an internal
cr_isapproxfunction that mimicsisapproxexcept we only accept a subset of the keyword arguments accepted byisapprox. Instead, we can just define methods forisapproxon ChainRules-defined types for the purposes of testing. That way we can more easily take arbitrary keyword arguments and get Test's special-cased pretty printing for@test a ≈ b.