Remove uses of similar to generate test inputs #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmoy
approved these changes
Nov 10, 2020
nickrobinson251
approved these changes
Nov 10, 2020
|
Did you intentionally check in ChainRulesTestUtils as a submodule? |
😱 OMG completely missed that in the review! (Feel like the one-line diff for addign a submodule hasn't helped us here * shakes fist at GitHub *) Pretty sure it wasn't intended (cc @oxinabox) |
|
It was very much not intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is why we have been getting non-determinstic failures, even thouh the RNG seed was set.
similarjust has whatever values was in RAM.Which could well be NaN.
Turns out it was not FiniteDifferences.jl v0.11 at all.