Minor code movement (NFC) and port some matrix types from Nabla #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM once we have testing for the new structured matrix types. |
|
Oh right, forgot that part. 😬 This was more plane work with insufficient sleep. |
|
|
* Move the BLAS definitions into the `linalg` directory. * Move some general optimizations into a specific utilities file for linear algebra definitions. * Consolidate structured matrix operations, e.g. diagonal and symmetric, into one file.
We're using it in the tests but were not declaring it as a test dependency. This seems to be the cause of the current Julia nightly failures on CI.
|
Finally got some time to finish this up. |
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.