Ensure scalar_rule rules are Number typed #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
previously requested changes
Jun 19, 2019
|
IIUC, will also need to update ChainRules.jl/src/rules/base.jl Line 41 in 1df670e ::Number, but ::RoundingMode)
|
Currently, `@scalar_rule` generates `rrule` methods with no type constraints. This poses a problem for rules with different definitions that have not yet been implemented. For example, the rule for matrix exponential is quite different from that for scalar exponential, but in the absence of an `rrule(::typeof(exp), ::AbstractMatrix)` method, the incorrect fallback generated by `@scalar_rule` is used. To solve this, `@scalar_rule` now allows type constaints, e.g. `@scalar_rule(f(x::Complex), g(x))`, and it adds explicit `::Number` constraints to the generated methods if no such constraints are provided.
ararslan
force-pushed
the
aa/scalar-number
branch
from
7b444f4
to
99dc361
Compare
|
Good notes, thanks! I've added a blurb about it to the docstring and added a |
|
Not sure what's up with the coverage drop. I think it doesn't like that I touched |
ararslan
dismissed
jrevels’s stale review
Requested changes have been implemented
nickrobinson251
added
the
type constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
@scalar_rulegeneratesrrulemethods with no type constraints. This poses a problem for rules with different definitions that have not yet been implemented. For example, the rule for matrixexponential is quite different from that for scalar exponential, but in the absence of an
rrule(::typeof(exp), ::AbstractMatrix)method, the incorrect fallback generated by@scalar_ruleis used.To solve this,
@scalar_rulenow allows type constraints, e.g.@scalar_rule(f(x::Complex), g(x)), and it adds explicit::Numberconstraints to the generated methods if no such constraints are provided.