Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use repr in show #530

Merged
merged 1 commit into from Jan 11, 2022
Merged

Don't use repr in show #530

merged 1 commit into from Jan 11, 2022

Conversation

mcabbott
Copy link
Member

This calls show(io, x) within show methods, so that arrays get truncated to your screen.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to bump the version.
I would count this as a bug-fix so patch

@mcabbott
Copy link
Member Author

mcabbott commented Jan 11, 2022

Also happy just to leave it on master until there's another reason to make a release? It's pretty close to non-functional.

@oxinabox
Copy link
Member

I don't hugely mind.
Releasing every PR is my preference because it makes working out where a bug was introduced easier.
But for things like this that are close to not functional change and are clearly not introducing a (significant) bug, it really doesn't matter one way or the other

@mcabbott mcabbott merged commit d9f4a44 into JuliaDiff:main Jan 11, 2022
@mcabbott mcabbott deleted the show branch January 11, 2022 19:31
@mcabbott mcabbott restored the show branch July 8, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants