Allow diff rule function to be in an expression or QuoteNode #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 0.7 changes the macro argument parsing to consistently use QuoteNodes instead of Expr(:quote...) objects (#23885). This also fixes some swapped LHS/RHS uses in the docs/variables.
|
Thanks for this!
Woah, I must've been having a pretty weird day when I wrote that code! Thanks for fixing those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current broken build and keeps the package compatible with
v0.6andv0.7after the change in expression parsing that putsSymbols inQuoteNodes instead ofExprobjects (JuliaLang/julia#23885).I also changed a few references to left-hand side (LHS) and right-hand side (RHS) which seemed backwards. Let me know if anything is missing or erroneous.
Thanks!