Merge pull request #241 from KristofferC/kc/show_type

stop overloading `show` on `Type`s
JuliaDiff · Nov 17, 2023 · 29057e2 · 29057e2
2 parents 871dea0 + 66a37f9
commit 29057e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/tangent.jl b/src/tangent.jl
@@ -304,6 +304,8 @@ wrapper_name(::Type{<:ZeroBundle}) = "ZeroBundle"
 wrapper_name(::Type{<:DNEBundle}) = "DNEBundle"
 wrapper_name(::Type{<:AbstractZeroBundle}) = "AbstractZeroBundle"
 
+#=
+# These methods cause too many invalidations to be feasible
 function Base.show(io::IO, T::Type{<:AbstractZeroBundle{N, B}}) where {N,B}
     print(io, wrapper_name(T))
     print(io, @isdefined(N) ? "{$N, " : "{N, ")
@@ -315,6 +317,7 @@ function Base.show(io::IO, T::Type{<:AbstractZeroBundle{N}}) where {N}
     print(io, wrapper_name(T))
     @isdefined(N) && print(io, "{$N}")
 end
+=#
 
 function Base.show(io::IO, t::AbstractZeroBundle{N}) where N
     print(io, wrapper_name(typeof(t)))

diff --git a/test/tangent.jl b/test/tangent.jl
@@ -16,6 +16,8 @@ using Test
 
     @testset "Display" begin
         @test repr(ZeroBundle{1}(2.0)) == "ZeroBundle{1}(2.0)"
+        #=
+        Overloading of Type printing is disabled for now
         @test repr(DNEBundle{1}(getfield)) == "DNEBundle{1}(getfield)"
 
         @test repr(ZeroBundle{1}) == "ZeroBundle{1}"
@@ -24,6 +26,7 @@ using Test
         @test repr((ZeroBundle{N, Float64} where N).body) == "ZeroBundle{N, Float64}"
 
         @test repr(typeof(DNEBundle{1}(getfield))) == "DNEBundle{1, typeof(getfield)}"
+        =#
     end
 end