Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put some guards on types allowed in TaylorTangents #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Oct 3, 2023

Not a high priority, and I am not sure if we want to do this.
Hopefully it is zero overhead by I am yet to check.

I found a case in the wild where I had screwed this up, by putting a ZeroTangent somewhere that should have gotten a ZeroTangent().
It's possible to screw this up both in Diffractor itself, but also in rule definitions. (though CRTU.jl will protect against the later)
It is nice to error as close to the creation of the bad type as possible to help work out what is triggering it

@oxinabox oxinabox requested a review from Keno October 3, 2023 04:09
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b3e4ee0) 55.05% compared to head (7f5d1df) 55.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   55.05%   55.10%   +0.04%     
==========================================
  Files          28       28              
  Lines        2810     2813       +3     
==========================================
+ Hits         1547     1550       +3     
  Misses       1263     1263              
Files Coverage Δ
src/tangent.jl 47.69% <100.00%> (+1.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant