Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookup demand-driven forward mode to the Diffractor runtime #99

Merged
merged 2 commits into from Jan 5, 2023

Conversation

Keno
Copy link
Collaborator

@Keno Keno commented Dec 31, 2022

Tests currently depend on JuliaLang/julia#48045 and JuliaLang/julia#48059, so we should either get those merged first, or mark them here as broken.

Tests currently depend on JuliaLang/julia#48045
and JuliaLang/julia#48059, so we should either
get those merged first, or mark them here as broken.
@codecov-commenter
Copy link

Codecov Report

Base: 52.68% // Head: 51.34% // Decreases project coverage by -1.34% ⚠️

Coverage data is based on head (064fc72) compared to base (88bc4c2).
Patch coverage: 64.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   52.68%   51.34%   -1.35%     
==========================================
  Files          27       27              
  Lines        2513     2604      +91     
==========================================
+ Hits         1324     1337      +13     
- Misses       1189     1267      +78     
Impacted Files Coverage Δ
src/higher_fwd_rules.jl 50.00% <0.00%> (-18.75%) ⬇️
src/stage2/lattice.jl 20.00% <0.00%> (-2.23%) ⬇️
src/codegen/forward_demand.jl 30.17% <62.96%> (-26.85%) ⬇️
src/stage2/interpreter.jl 21.36% <63.63%> (+8.36%) ⬆️
src/stage2/forward.jl 96.66% <94.44%> (-3.34%) ⬇️
src/stage1/forward.jl 71.91% <100.00%> (ø)
src/stage1/generated.jl 72.48% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Keno Keno merged commit b293bbd into main Jan 5, 2023
@oscardssmith oscardssmith deleted the kf/demanddiffractor branch January 5, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants