Dispatch on StaticArray instead of SArray #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also should fix FieldVector |
|
Test errors are fixed by JuliaDiff/DiffResults.jl#7. |
|
Since JuliaDiff/DiffResults.jl#7 was merged and released, tests should pass with the latest version of DiffResults |
|
I've re-triggered CI, fingers crossed 🙂 |
|
Hmm... It seems the test errors on Windows are not related to this PR? |
|
yup looks like #387 |
|
Huh? How is that related? This looks like a tolerance error? |
|
Oh I thought the purpose of that was to update AppVeyor and fix Win32 tests. I don't know why I thought the latter part. |
|
Yup, windows issues are unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only
SArrays are supported and no otherStaticArrays such asSLArrays (https://github.com/JuliaDiffEq/LabelledArrays.jl). Together with a similar PR to DiffResults this seems to fix issues I experienced withSLArrays without breaking existingSArraysupport. However, since we do not dispatch on the mutability of the static arrays unfortunately evenDiffResults for mutable static arrays such asMArraywill be immutable.