broadcasting perf fix #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure needs some work. I won't be able to come back to this for at least 3 days. |
|
bump on this 😄 |
|
Will get on it after I upload my JuliaCon presentation :) |
|
Alright thanks! |
|
Sorry for the delay. I am on it. |
|
The test failure is a StackOverFlow when computing the Hessian of a function with broadcasting. Working on a fix. |
|
Tests should pass now. |
This was referenced Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports some code from DistributionsAD.jl to improve the performance of broadcasting in ReverseDiff allow for fused broadcast expressions with TrackedArray inputs to give a TrackedArray output where possible and provably correct. The implementation details and decisions are explained in TuringLang/DistributionsAD.jl#58 (comment). I still need to add some t ests.