CompatHelper: bump compat for "SpecialFunctions" to "1.0" #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
ForwardDiff is now compatible with SpecialFunctions 1.0, so finally I can run tests of ReverseDiff with SpecialFunctions 1.0 locally. @mohamed82008 Can you rerun the tests here and release the compatibility update in case nothing is broken? A compatible version of ReverseDiff is required for the tests in DistributionsAD, and hence it is needed for updating all the Turing packages to SpecialFunctions 1.0. |
mohamed82008
force-pushed
the
compathelper/new_version/2020-11-18-00-11-22-279-2492702306
branch
from
88411b9
to
03f81bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 18 18
Lines 1462 1462
=======================================
Hits 1194 1194
Misses 268 268 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
SpecialFunctionspackage from0.8, 0.9, 0.10to0.8, 0.9, 0.10, 1.0.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.