Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS paper #181

Merged
merged 5 commits into from Sep 22, 2018
Merged

JOSS paper #181

merged 5 commits into from Sep 22, 2018

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Sep 20, 2018

No description provided.

@coveralls
Copy link

coveralls commented Sep 20, 2018

Coverage Status

Coverage remained the same at 97.99% when pulling c443ff1 on lb/joss into 2559f83 on master.

Copy link
Contributor

@dpsanders dpsanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@lbenet
Copy link
Member Author

lbenet commented Sep 20, 2018

Thanks for reviewing this. I agree and have implemented all suggestions.

@lbenet
Copy link
Member Author

lbenet commented Sep 20, 2018

I've just pushed another commit with your last suggestion. Thanks a lot!

@lbenet
Copy link
Member Author

lbenet commented Sep 22, 2018

Merging, to allow JOSS review go on.

@lbenet lbenet merged commit 3434e51 into master Sep 22, 2018
@lbenet lbenet deleted the lb/joss branch December 13, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants