Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further mathematical consistency with the big O notation #248

Merged
merged 14 commits into from Apr 29, 2021
Merged

Further mathematical consistency with the big O notation #248

merged 14 commits into from Apr 29, 2021

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Jul 9, 2020

No description provided.

@lbenet lbenet linked an issue Jul 9, 2020 that may be closed by this pull request
Order behavior of integrate and derivative for univariate Taylor series #230
Closed
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited

Coverage Status

Coverage decreased (-0.08%) to 96.12% when pulling 4ce2e3f on lb/iss230 into dfb3f15 on master.

@lbenet lbenet mentioned this pull request Jul 9, 2020
Closed
@lbenet lbenet force-pushed the lb/iss230 branch 2 times, most recently from 463d553 to e86c706 Compare April 9, 2021 21:00
@lbenet lbenet mentioned this pull request Apr 13, 2021
Closed
@lbenet lbenet mentioned this pull request Apr 20, 2021
Closed
@lbenet
Copy link
Member Author

lbenet commented Apr 21, 2021

This is ready for review. The changes proposed are breaking with respect to the last tagged version, so wee should tag a new minor version.

Could you review this PR @dpsanders?

@lbenet
Copy link
Member Author

lbenet commented Apr 21, 2021

Closes #230, #268 and #275

@lbenet
Copy link
Member Author

lbenet commented Apr 28, 2021

Bump: @dpsanders could you review this PR?

dpsanders
dpsanders reviewed Apr 28, 2021
View reviewed changes
docs/src/userguide.md Outdated Show resolved Hide resolved
docs/src/userguide.md Outdated Show resolved Hide resolved
docs/src/userguide.md Outdated Show resolved Hide resolved
docs/src/userguide.md Outdated Show resolved Hide resolved
src/calculus.jl Outdated Show resolved Hide resolved
src/calculus.jl Outdated Show resolved Hide resolved
@dpsanders
Copy link
Contributor

LGTM as far as I can tell, apart from a few spellings that I noted.
But I am not familiar with the code so don't take my opinion too seriously!

If tests pass then it seems good.

Thanks!

@dpsanders
Copy link
Contributor

Does integrating increase the order by 1?

@lbenet
Copy link
Member Author

lbenet commented Apr 29, 2021

Thanks a lot for reviewing this PR.

Aside from fixing the typos, I've also updated Project.toml to bump a new minor version, since the changes are somewhat breaking.

@lbenet
Copy link
Member Author

lbenet commented Apr 29, 2021

Regarding your questions, integrate does not increase the order, yet. The reason is that, doing that breaks TaylorModels, and I prefer to have the time to work both things together.

@lbenet
Copy link
Member Author

lbenet commented Apr 29, 2021

Merging...

@lbenet lbenet merged commit 4421e17 into master Apr 29, 2021
@lbenet lbenet deleted the lb/iss230 branch April 30, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpsanders dpsanders dpsanders left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order behavior of integrate and derivative for univariate Taylor series
3 participants
@lbenet @coveralls @dpsanders