-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make index_table
a Vector{Vector{UInt128}}, and add tests
#86
Conversation
This will slow down (I would guess by rather a lot) every single calculation with the package. I think a better solution is the one I posted in #85 (comment) although that will require more work to make everything type stable again. |
Both statements are correct. Running
I also agree with this. Yet, this is quite tricky, since the choice must depend on the values. A possible approach could be to define a (global) parameter which fixes the parameterization of |
@PerezHz The performance hit is important, and as @dpsanders states, it is not common to have situations where the used hashed numbers is so important. I suggest that you use the branch "index_table" to get access to what has been done here. |
I think we should move away from any kind of global table. Then each Taylor polynomial can store a reference to an object of the relevant type / size. |
I agree that we should look for alternatives (including moving away from the global table scheme), but if such alternatives involve memory overhead, I don't think that's the way to go. |
I closed this, |
Thanks @lbenet and @dpsanders for the work you are putting into this; it is helping me a lot! Perhaps a note should be added in the documentation regarding the fact that |
This is a small modification addressing [#85]. It simply carries
on the hashing of the vectors of integers in
UInt128
arithmetic.