Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WOperator error when the Jacobian is lazy #834

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Conversation

YingboMa
Copy link
Member

We want to use eltype(B) because it is always concrete.

@coveralls
Copy link

coveralls commented Jul 16, 2019

Coverage Status

Coverage remained the same at 77.916% when pulling 083f5ae on myb/fix into 9876d03 on master.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #834 into master will decrease coverage by 5.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   80.22%   74.36%   -5.87%     
==========================================
  Files          88       88              
  Lines       29435    29361      -74     
==========================================
- Hits        23614    21833    -1781     
- Misses       5821     7528    +1707
Impacted Files Coverage Δ
src/derivative_utils.jl 75.58% <100%> (-0.39%) ⬇️
src/tableaus/rkc_tableaus.jl 0% <0%> (-100%) ⬇️
src/caches/rkc_caches.jl 23.17% <0%> (-74.73%) ⬇️
src/perform_step/rkc_perform_step.jl 15.77% <0%> (-71.53%) ⬇️
src/caches/ssprk_caches.jl 43.93% <0%> (-38.16%) ⬇️
src/caches/low_storage_rk_caches.jl 57.41% <0%> (-32.13%) ⬇️
src/rkc_utils.jl 48.27% <0%> (-27.02%) ⬇️
src/alg_utils.jl 16.93% <0%> (-15.32%) ⬇️
src/perform_step/ssprk_perform_step.jl 69.81% <0%> (-15.22%) ⬇️
src/caches/low_order_rk_caches.jl 77.72% <0%> (-10.43%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9876d03...083f5ae. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 2598af7 into master Jul 18, 2019
@ChrisRackauckas ChrisRackauckas deleted the myb/fix branch July 18, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants