Skip to content

Commit

Permalink
Create new files instead of copying internal resources. (#1497)
Browse files Browse the repository at this point in the history
  • Loading branch information
fredrikekre committed Dec 16, 2020
1 parent b68e2d9 commit ee0d535
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,9 @@
# Documenter.jl changelog

## Version `v0.26.1`

* ![Bugfix][badge-bugfix] HTML assets that are copied directly from Documenters source to the build output now has correct file permissions. ([#1497][github-1497])

## Version `v0.26.0`

* ![BREAKING][badge-breaking] The PDF/LaTeX output is again provided as a Documenter built-in and can be enabled by passing an instance of `Documenter.LaTeX` to `format`. The DocumenterLaTeX package has been deprecated. ([#1493][github-1493])
Expand Down Expand Up @@ -717,6 +721,7 @@
[github-1489]: https://github.com/JuliaDocs/Documenter.jl/pull/1489
[github-1491]: https://github.com/JuliaDocs/Documenter.jl/pull/1491
[github-1493]: https://github.com/JuliaDocs/Documenter.jl/pull/1493
[github-1497]: https://github.com/JuliaDocs/Documenter.jl/pull/1497

[julia-38079]: https://github.com/JuliaLang/julia/issues/38079

Expand Down
2 changes: 1 addition & 1 deletion Project.toml
@@ -1,6 +1,6 @@
name = "Documenter"
uuid = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
version = "0.26.0"
version = "0.26.1"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
5 changes: 4 additions & 1 deletion src/Writers/HTMLWriter.jl
Expand Up @@ -707,7 +707,10 @@ function copy_asset(file, doc)
else
ispath(dirname(dst)) || mkpath(dirname(dst))
ispath(dst) && @warn "overwriting '$dst'."
cp(src, dst, force=true)
# Files in the Documenter folder itself are read-only when
# Documenter is Pkg.added so we create a new file to get
# correct file permissions.
open(io -> write(dst, io), src, "r")
end
assetpath = normpath(joinpath("assets", file))
# Replace any backslashes in links, if building the docs on Windows
Expand Down

2 comments on commit ee0d535

@fredrikekre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/26466

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.26.1 -m "<description of version>" ee0d535e519704c4a6148cb0b3c225ad07517ead
git push origin v0.26.1

Please sign in to comment.