Fix text/latex output in HTMLWriter #1283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
commented
Apr 9, 2020
mortenpi
commented
Apr 9, 2020
| # If the show(io, ::MIME"text/latex", x) output is already wrapped in \[ ... \], we | ||
| # unwrap it first, since when we output Markdown.LaTeX objects we put the correct | ||
| # delimiters around it anyway. | ||
| m = match(r"\s*\\\[(.*)\\\]\s*", d[MIME"text/latex"()]) |
There was a problem hiding this comment.
The stripping of \[ and \] is directly motivated by SymPy. I am wondering if we should also strip $ .. $,$$ .. $$, \( .. \) etc.
There was a problem hiding this comment.
Seems reasonable to me to be consistent here and just strip them all.
|
Thanks, I had a similar fix on some machine. The tricky thing here is what should happen with something like where not everything is math. |
|
Fair point, this may need a little bit more thought. It looks like it might end up being slightly breaking though, so let's leave this for 0.25.0. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to fix #1278.