Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve copy button JS #1754

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Improve copy button JS #1754

merged 2 commits into from
Jan 17, 2022

Conversation

pfitzseb
Copy link
Member

Fixes #1753.

@pfitzseb pfitzseb marked this pull request as draft January 17, 2022 11:22
@pfitzseb pfitzseb marked this pull request as ready for review January 17, 2022 11:32
@pfitzseb pfitzseb mentioned this pull request Jan 17, 2022
Closed
@fredrikekre
Copy link
Member

I'm okay with limiting this to https, but the patch doesn't look too complicated, so why not.

@fredrikekre fredrikekre merged commit 6369e2e into master Jan 17, 2022
@fredrikekre fredrikekre deleted the sp/better-copy-js branch January 17, 2022 13:43
@fredrikekre fredrikekre removed their request for review January 17, 2022 13:43
@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bugfix labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy button does't working
3 participants
@pfitzseb @fredrikekre @mortenpi