Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new HTML front end with Bulma #1043

Merged
merged 23 commits into from Aug 12, 2019
Merged

Implement a new HTML front end with Bulma #1043

merged 23 commits into from Aug 12, 2019

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jun 24, 2019

Demo:

TODO:

  • Need to add the SCSS sources, requires basic APIs in DocumenterTools
  • Handle tables overflowing
  • Fix the search page
  • Revise sidebar menu styling, layout (close Navigation sidebar not usable on iPad #638)
  • Try out a few other fonts
  • Footnote "back-references" (click on def, jump to location)
  • Colophon (for now, it's implemented as a settings dialog; close “When was the documentation last updated?” #724)
  • Flakiness when clicking on search results? (Seems fine now)
  • It seems that sidebar vertical height can be buggy on mobile when the browser top bar disappears.
  • Page Down does not scroll the main body by default (since the scrollbar is actually for an inner <div>; won't fix now, but might revisit the use of bulma-dashboard)
  • Footer theming
  • Fiddle with the color scheme (close Note section in new darkly theme #1085)
  • Syntax highlighting in admonitions in the dark theme.
  • Different logo for dark theme (Different logo for dark themes #1090)
  • Fix note admonition styling (close Style info admonitions correctly #1030)
  • Link to point to the GitHub repo root
  • List margins

Close #626, close #722. Also addresses #981, #618.

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Jun 24, 2019
@mortenpi mortenpi added this to the 0.24.0 milestone Jun 24, 2019
margin-bottom: auto;
&::before {
@include font-awesome;
content: "\f054";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make it specific to levels > 1, then you can put something like

margin-left: -1em;
margin-right: 0;
background: $sidebar-background;

here to get what I showed on Slack.

@cormullion
Copy link
Contributor

I love this, especially the Dark Mode, which is always interesting to design for. I wonder whether the Notes (if not the Warnings) could be dimmed a bit, so as not to be so distracting...?

docs-darkmode

Also, I think the Julia logo could be inverted?

Anyway, it looks great!

@Datseris
Copy link
Contributor

Hello! Just came here to add exactly the same comment as @cormullion , but of course cormullion being cormullion did it much before me! I also thing the warning boxes should use a bit more saturated colors. It makes it easier on the eyes. Also, a light gray background over the text in the white version would help (as at the moment you cant really tell when the block ends)

@mortenpi
Copy link
Member Author

mortenpi commented Aug 4, 2019

Also, I think the Julia logo could be inverted?

Good idea, although I need to think about how to implement it (the logo and the theme are not technically related to each other). Do you have an SVG of the inverted logo by any chance though?

@pfitzseb
Copy link
Member

pfitzseb commented Aug 5, 2019

Do you have an SVG of the inverted logo by any chance though?

See here or here.

@cormullion
Copy link
Contributor

https://github.com/JuliaLang/julia-logo-graphics/tree/master/images

@mortenpi
Copy link
Member Author

mortenpi commented Aug 6, 2019

I left the colors slightly more saturated than what @cormullion suggested at the moment:

admonitions

I feel that they are dimmed enough, yet nicely retain some colorfulness. Overall, I think I managed to take care of most color issues now (not the logo yet though). Feedback most welcome though. Here is the latest demo:

https://mortenpi.eu/gsoc2019-mockups/bulma/v10/documenter/showcase/
https://mortenpi.eu/gsoc2019-mockups/bulma/v10/julia/

@cormullion
Copy link
Contributor

Lower contrast is great now.

(de gustibus non est disputandum) 😅

@cormullion
Copy link
Contributor

On the Settings menu, is that "generated by Documenter... " the date of the document's generation (fixing #724 yay!), or something to do with the settings?

@mortenpi
Copy link
Member Author

mortenpi commented Aug 7, 2019

On the Settings menu, is that "generated by Documenter... " the date of the document's generation (fixing #724 yay!), or something to do with the settings?

That's when the document was generated (you can hover to see the time too). I put it into the settings dialog since I couldn't really figure out how to make it look readable and unobtrusive at the same time in the footer.

@cormullion
Copy link
Contributor

Perhaps you could include the document name there, so that it's clear that it's this specific document, not the Documenter HTML theme, or whatever?

@mortenpi mortenpi marked this pull request as ready for review August 8, 2019 06:55
@mortenpi
Copy link
Member Author

mortenpi commented Aug 8, 2019

In case anyone is brave enough to review any of this, then now would be the time. I will appreciate any feedback 🙂 Generally, I think it's in good enough shape to be merged (we'll probably have some fixes in follow-up PRs), but I'll leave it open for a few more days.

@mortenpi
Copy link
Member Author

mortenpi commented Aug 9, 2019

Hmm, might be better to go back to Roboto Mono then, but have a slightly better fallback behavior than before:

font-family: 'Roboto Mono', 'SFMono-Regular', 'Menlo', 'Consolas', 'Liberation Mono', 'DejaVu Sans Mono', monospace;

Or, alternatively, we could try to target the OS default monospace fonts:

font-family: 'SFMono-Regular', 'Menlo', 'Consolas', 'Liberation Mono', 'DejaVu Sans Mono', monospace;

I don't really have a very strong opinion myself. The alignment problem of #618 is pretty much unsolvable, and not really a problem for the Julia manual anyway, so we can just focus on which one looks better.

Uses #222 now for main text, like the current manual.
* Use Roboto Mono + sytem fallbacks for monospace
* Update sans-serif fallbacks
* Make sure the dark theme uses same fonts
@helgee
Copy link
Contributor

helgee commented Aug 9, 2019

Yup, those are correct. Although they don't come from Markdown -- they are just bullet points for the in-page headings, and intentionally look different from the rest of the sidebar in order to distinguish them from the inter-page links.

Maybe a different bullet, i.e. one that is not the same as Julia's comment character and Markdown headers, would be better? ;-)

BTW: This looks great 👍

@tkf
Copy link
Contributor

tkf commented Aug 10, 2019

It seems that syntax highlighting is broken:

image

from https://mortenpi.eu/gsoc2019-mockups/bulma/v7/documenter/man/syntax/#@ref-link-1

This happens if:

  • You never visited the page (or cleared the cache?)
  • And never switched to the dark theme.

Switching to the dark theme and then switching back to the default gives me:

image

@mortenpi
Copy link
Member Author

@tkf Do you see the same issue with a newer version too?

https://mortenpi.eu/gsoc2019-mockups/bulma/v11/documenter/man/syntax/#@ref-link-1

@tkf
Copy link
Contributor

tkf commented Aug 10, 2019

Looks good to me. I didn't realize that the link in the OP was an older version.

@mortenpi
Copy link
Member Author

Maybe a different bullet, i.e. one that is not the same as Julia's comment character and Markdown headers, would be better? ;-)

I personally actually like that it mirrors the Markdown syntax since you create those headings literally with a # (well, with ## normally).

Here are the latest builds (also updated the OP):

https://mortenpi.eu/gsoc2019-mockups/bulma/v13/documenter/
https://mortenpi.eu/gsoc2019-mockups/bulma/v13/julia/

@helgee
Copy link
Contributor

helgee commented Aug 11, 2019

I personally actually like that it mirrors the Markdown syntax since you create those headings literally with a # (well, with ## normally).

I see your point and I certainly could get used to it. It just sticks out a bit especially if juxtaposed with other bulleted lists (see below) and like @cormullion, I first interpreted it as a rendering error.

grafik

@ararslan
Copy link
Member

I didn't even realize the hashes were intentional; I also thought they were an error.

@mortenpi
Copy link
Member Author

I didn't even realize the hashes were intentional; I also thought they were an error.

Ok, three people reporting it means that it's no longer a matter of taste 😆 Swapped it out for circles:

circles

@mortenpi mortenpi merged commit d5562a8 into master Aug 12, 2019
@mortenpi
Copy link
Member Author

I merged this so that any follow-up changes could be made in separate, more manageable PRs. This does not mean that any of the style etc. is final yet -- I opened a dedicated issue to collect feedback: #1091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
8 participants