Support REPL softscope for Julia 1.5. #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that it always matches at least one line of real stacktrace before it does the replacement. Otherwise the regex may throw an error.
mortenpi
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
LGTM, thanks @fredrikekre! Added a bit more testing and some docs.
| @@ -1,5 +1,9 @@ | |||
| # Documenter.jl changelog | |||
|
|
|||
| ## Version `v0.24.5` | |||
|
|
|||
| * ![Enhancement][badge-enhancement] ![Bugfix][badge-bugfix] Documenter now correctly emulates the "REPL softscope" (Julia 1.5) in REPL-style doctest blocks and `@repl` blocks. ([#1232][github-1232]) | |||
There was a problem hiding this comment.
Suggested change
| * ![Enhancement][badge-enhancement] ![Bugfix][badge-bugfix] Documenter now correctly emulates the "REPL softscope" (Julia 1.5) in REPL-style doctest blocks and `@repl` blocks. ([#1232][github-1232]) | |
| * ![Enhancement][badge-enhancement] ![Bugfix][badge-bugfix] Documenter now correctly emulates the "REPL softscope" in REPL-style doctest blocks and `@repl` blocks (Julia 1.5 and above). ([#1232][github-1232]) |
briochemc
added a commit
to briochemc/Documenter.jl
that referenced
this pull request
Apr 10, 2020
* JuliaDocs-master: (138 commits) Add example admonition css to example build (JuliaDocs#1284) Pass non-standard admonition categories on in HTML output (JuliaDocs#1280) Suggest using the `aligned` environment (JuliaDocs#1275) Update DiffEq docs link (JuliaDocs#1274) Make Deps.pip a closure again (JuliaDocs#1240) Recommend Julia 1.4 in the manual (JuliaDocs#1272) Add note about doctests in docstrings (JuliaDocs#1265) Fix minted/lstlistings escaping (JuliaDocs#1269) Changelog for 0.24.7 (JuliaDocs#1266) Test with Julia 1.4 instead of 1.3 on CI (JuliaDocs#1268) Fix doctest testing on nightly (JuliaDocs#1267) remove "only" from search stop word filter (JuliaDocs#1264) Reorganize some Sass variables to make theming easier (JuliaDocs#1258) Fix outdated links in the manual (JuliaDocs#1255) Fix LaTeX tests for tags (JuliaDocs#1256) Install TagBot as a GitHub Action (JuliaDocs#1237) use Julia 1.3 for .travis hosting example (JuliaDocs#1235) Set version to 0.24.5 (JuliaDocs#1233) Support REPL softscope for Julia 1.5. (JuliaDocs#1232) Discourage use of matrix: in Travis conf (JuliaDocs#1231) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaLang/julia#33864 and JuliaLang/julia#34567.