On Hover Footnote Preview #2522
Conversation
|
Nice. This would be awesome to have for docstring references too, but might be a bit more tricky since it doesn't have to be on the same page. |
I can look into that if you can just tell me the part of codebase which deals with it! |
There was a problem hiding this comment.
Very nice feature, and the implementation looks very clean!
I've verified that this does not break anything when viewing the documentation with a non-js terminal browser like w3m.
One detail: I've had some interest in this kind of hover functionality, where I was hoping to re-use a future implementation for hover on footnotes (i.e., this implementation) for hover of bibliographic references as well, see JuliaDocs/DocumenterCitations.jl#67
It seems like that might work with this if I add the .footnote-reference class to the citation link in the rendered HTML. And then I would presumably need to add some extra hidden "preview text" to the page that contains some version of fully rendered reference.
I would like to understand a little better what requirements the JS in this PR imposes on any such preview text. See also @fredrikekre's comment about generalizing this to even more things like docstrings.
Thus, I might suggest naming everything not specifically in relation to "footnote" but in relation to "hover" to make it more general, and reusable by plugins.
This is somewhat optional. I don't want to hold up this PR by unreasonably complicating matters, but it might be worth taking into consideration.
| // libraries: jquery | ||
| // arguments: $ | ||
|
|
||
| $(document).ready(function() { |
There was a problem hiding this comment.
I think this is where it actually sets the preview text that will be shown on hover, right?
Can you elaborate a little on what assumptions this makes on the HTML of the footnote? I'm trying to figure out if these assumptions hold / could be made to hold for bibliographic references as well.
There was a problem hiding this comment.
Actually, this is used to get the footnote content in hidden span for preview! This jQuery code takes the footnote definitions from the end of the page and puts it into the hidden spans just under the footnotes based on their footnote IDs!
For bibliographic references, we will need another way because the references are in another file and not on same page!
We can add a hidden span in Julia part like this:
span[".footnote-preview", :id => "fn-$(f.id)"](footnote content comes here using that JQuery!)
We can add a small julia function which stores bibliographic reference on pages its being used on and then add them in span! This way we can use this method for all things that require hover preview feature whether it is footnotes, bibliographic references or docstring references!
We will just need those small julia functions for storing content and put them in span and similar css can be used for all, No Javascript or JQuery will be needed and this is most efficient way!
I used JQuery because I was not able to fetch content using Julia (lack of my expertise)
There was a problem hiding this comment.
For bibliographic references, we will need another way because the references are in another file and not on same page!
That's probably not that much of an issue: I wouldn't mind adding (hidden) bibliography items on each page for anything that's being referenced on that page, just for the hover to be able to pick up the text for there. But there should be some existing JS to hook into (i.e., this PR) for showing the hover: I'd like to avoid having to instruct people using the plugin to manually set up JS.
| @@ -0,0 +1,35 @@ | |||
| .footnote-reference { | |||
There was a problem hiding this comment.
Maybe name these, e.g., .hover-reference and .hover-preview to make them more general for things beyond footnotes, like citations?
There was a problem hiding this comment.
for now until jQuery is being used we can only use this for footnotes but if can we use Julia for adding content then it will be better to change this to global use for preview features in all parts!
|
Very cool! It looks like you can run into some "layout" issues when you have small windows or are close to edges I guess:
I don't know if there are any easy ways to work around this or not. We can always iterate on it later as well, if there aren't. A few other thoughts:
Generally, I think I'd be happy to merge this pretty much as is, and iterate in follow-up PRs. Or if you want to fiddle with it a bit more, we can also wait. |
|
I would be happy if you can wait a little! Sorry, actually I did not test it on small windows! I will make some changes in it as soon as I get some time! |
Added On-Hover Footnote Preview feature!
I used a small jQuery script for fetching the footnote definitions from the end of the page and its working very fine!
closes #2080