no rounding of search and version selector #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm basically neutral on the matter. This choice is from the original Sphinx theme. I am slightly sceptical of making these small subjective changes since you can go back and forth indefinitely. But since there seems to be support for this I propose let's leave this open for a week or two and, if there are no dissenting opinions, merge then. The slight rounding of the selector you have seems to be platform dependent. For reference, this is what is looks like on Ubuntu / Gnome:
|
|
Alright, I'll just configure these small things in my own css from now on. I think we can close this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must admit that I find the rounding of the search and version selector quite ugly. This changes it to be just rectangular.
After: