Fixup redirected output #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success perhaps?
Was the problem intermittent or happening every time without fail? |
|
I'll rebuild that job a couple of times to check for sure. |
MichaelHatherly
force-pushed
the
mh/redirect-output
branch
from
df28327
to
9ebf7df
Compare
Current coverage is 81.52%@@ master #93 diff @@
==========================================
Files 14 14
Lines 857 866 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 734 706 -28
- Misses 123 160 +37
Partials 0 0
|
MichaelHatherly
force-pushed
the
mh/redirect-output
branch
from
9ebf7df
to
d987dfd
Compare
|
Issue #45 for
cc: @Ward9250, @bicycle1885 if you get a chance to test this out locally as well that would be great. |
|
I just checked it in my mac, and it the problem is gone, including julia 0.4 ! Thank you very much! |
|
Excellent! Thanks for checking @lbenet. |
MichaelHatherly
force-pushed
the
mh/redirect-output
branch
from
d987dfd
to
50a41e8
Compare
Don't create new tasks for each redirect and only redirect the `STDOUT` and `STDERR` streams once during `Document` construction. Might help solve the OSX issues related to hanging and too many open files.
MichaelHatherly
force-pushed
the
mh/redirect-output
branch
from
50a41e8
to
744944c
Compare
This was referenced Jun 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't create new tasks for each redirect and only redirect the
STDOUTandSTDERRstreams once duringDocumentconstruction.Might help solve the OSX issues related to hanging and too many open files.
@lbenet, if you have the chance to test this out that would be great, might potentially help with #44.