Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update celllistmap.jl example #1028

Merged
merged 2 commits into from
May 3, 2024
Merged

Update celllistmap.jl example #1028

merged 2 commits into from
May 3, 2024

Conversation

lmiq
Copy link
Contributor

@lmiq lmiq commented May 2, 2024

This updates the CellListMap integration example to use the renamed ParticleSystem syntax, which was introduced in version 0.9.0 and will become the standard in a future 1.0 release. No functionality was changed.

This updates the CellListMap.jl to use the new `ParticleSytem` syntax, which was introduced in version 0.9.0 and will become the standard in a future 1.0 release.
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (8b5b456) to head (1e5b494).
Report is 108 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1028       +/-   ##
===========================================
+ Coverage   70.12%   86.50%   +16.38%     
===========================================
  Files          42       39        -3     
  Lines        2718     2550      -168     
===========================================
+ Hits         1906     2206      +300     
+ Misses        812      344      -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Datseris
Copy link
Member

Datseris commented May 2, 2024

Thanks, but don't you also have to change the version in docs/project.toml: https://github.com/JuliaDynamics/Agents.jl/blob/main/docs/Project.toml#L36 ? since this will be the syntax in 1.0, maybe change it to 0.9, 1.0?

@lmiq
Copy link
Contributor Author

lmiq commented May 2, 2024

Thanks, but don't you also have to change the version in docs/project.toml: https://github.com/JuliaDynamics/Agents.jl/blob/main/docs/Project.toml#L36 ? since this will be the syntax in 1.0, maybe change it to 0.9, 1.0?

Yes, thanks. I didn't know about having a Project.toml file that actually was used on deployment. Fixed.

I'll let the 1.0 for when it is available, after some testing of the new interface.

@Datseris Datseris merged commit 6966f9a into JuliaDynamics:main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants