Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SIR example #1029

Merged
merged 5 commits into from
May 6, 2024
Merged

fix SIR example #1029

merged 5 commits into from
May 6, 2024

Conversation

rakvat
Copy link
Contributor

@rakvat rakvat commented May 6, 2024

This fixes the SIR example for me.

Might fix #1026

@Tortar
Copy link
Member

Tortar commented May 6, 2024

thanks a lot!! We actually track the step of the simulation through abmtime so I update your fix with it :-)

@Tortar
Copy link
Member

Tortar commented May 6, 2024

Let's see if on the online docs everything works fine now after it builds

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (8b5b456) to head (31e9017).
Report is 109 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1029       +/-   ##
===========================================
+ Coverage   70.12%   86.50%   +16.38%     
===========================================
  Files          42       39        -3     
  Lines        2718     2550      -168     
===========================================
+ Hits         1906     2206      +300     
+ Misses        812      344      -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/sir.jl Outdated Show resolved Hide resolved
@Tortar Tortar merged commit 4715873 into JuliaDynamics:main May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIR video is completely white
3 participants