-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A first attempt to test visualization code #888
Conversation
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
===========================================
+ Coverage 72.72% 92.45% +19.72%
===========================================
Files 42 32 -10
Lines 2871 2319 -552
===========================================
+ Hits 2088 2144 +56
+ Misses 783 175 -608
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
As expected we got a big boost in coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evaluating code coverage in the plots folder was a mistake. I didn't realize it. We need to remove this, irrespectiveily of whether we test the plotting or not.
See here for how to remove folders from the coverage: https://github.com/JuliaDynamics/Attractors.jl/blob/main/codecov.yml
Actually now the boost is even better :D |
This is very rough, but at least we have something, so in my opinion it is nonetheless a good thing. Partially address #864
Notice that I needed to change "Zombie" in "Zombiee" in
jld2tests.jl
because it conflicted with the "Zombie" in the examples folder. This is caused by the current design of the agent macro which always evaluates the quote at the module scope. We should fix this