Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A first attempt to test visualization code #888

Merged
merged 8 commits into from
Sep 24, 2023
Merged

A first attempt to test visualization code #888

merged 8 commits into from
Sep 24, 2023

Conversation

Tortar
Copy link
Member

@Tortar Tortar commented Sep 23, 2023

This is very rough, but at least we have something, so in my opinion it is nonetheless a good thing. Partially address #864

Notice that I needed to change "Zombie" in "Zombiee" in jld2tests.jl because it conflicted with the "Zombie" in the examples folder. This is caused by the current design of the agent macro which always evaluates the quote at the module scope. We should fix this

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #888 (f2b977b) into main (e1e58a7) will increase coverage by 19.72%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #888       +/-   ##
===========================================
+ Coverage   72.72%   92.45%   +19.72%     
===========================================
  Files          42       32       -10     
  Lines        2871     2319      -552     
===========================================
+ Hits         2088     2144       +56     
+ Misses        783      175      -608     
Files Changed Coverage Δ
src/core/model_abstract.jl 90.76% <100.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Tortar
Copy link
Member Author

Tortar commented Sep 23, 2023

As expected we got a big boost in coverage

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evaluating code coverage in the plots folder was a mistake. I didn't realize it. We need to remove this, irrespectiveily of whether we test the plotting or not.

See here for how to remove folders from the coverage: https://github.com/JuliaDynamics/Attractors.jl/blob/main/codecov.yml

Project.toml Show resolved Hide resolved
@Tortar
Copy link
Member Author

Tortar commented Sep 24, 2023

Actually now the boost is even better :D

@Tortar Tortar merged commit ce828f8 into main Sep 24, 2023
6 checks passed
@Tortar Tortar deleted the vis-tests branch September 24, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants