New algorithm for detection of UPOs #328
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 54.86% 61.10% +6.23%
==========================================
Files 22 25 +3
Lines 904 1036 +132
==========================================
+ Hits 496 633 +137
+ Misses 408 403 -5 ☔ View full report in Codecov by Sentry. |
|
I'll fix the docs in this PR and then review... |
src/periodicity/davidchacklai.jl
Outdated
| The main difference between Schmelcher & Diakonos[^Schmelcher1997] and | ||
| Davidchack & Lai[^Davidchack1999] is that the latter uses periodic points of | ||
| previous period as seeds to detect periodic points of the next period. | ||
| Additionally, `periodicorbits` only detects periodic points of a given order, |
There was a problem hiding this comment.
When you are referring to a function wrap it in an @ref decorator;
[`periodicorbit`](@ref)
src/periodicity/davidchacklai.jl
Outdated
| davidchacklai(ds::DeterministicIteratedMap, n::Int, ics, m::Int; kwargs...) -> fps | ||
|
|
||
| Find periodic orbits `fps` of orders `1` to `n` for the map `ds` | ||
| using the algorithm propesed by Davidchack & Lai[^Davidchack1999]. |
There was a problem hiding this comment.
LEt's prepare ourselves for using documenter citations.
Create a new file docs/refs.bib. Add there the BiBtex entry for DavidCha1999. Cite it using
[DavidChack1999](@cite)
and in the docs/make.jl uncomment the corresponding Bibliography related code.
|
I am merging this in, we don't have a changelog entry yet, but you mentioned you will do this in a different PR! |
Hi!
I have added Davidchack-Lai algorithm for detection of unstable periodic orbits: https://journals.aps.org/pre/abstract/10.1103/PhysRevE.60.6172
https://www.sciencedirect.com/science/article/pii/S0375960101004637
I have included docstring and tests. I have also wrote examples for documentation, however I don't know how to create the documentation website locally, so I haven't seen the output. When I run /docs/make.jl it results in an error even without my additions.