Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve circular dependencies #94

Open
Datseris opened this issue Jul 31, 2021 · 4 comments
Open

Resolve circular dependencies #94

Datseris opened this issue Jul 31, 2021 · 4 comments
Labels
good first issue Good for newcomers low priority tests Related with the testing suite

Comments

@Datseris
Copy link
Member

DynamicalSystemsBase.jl depends on DelayEmbeddings.jl. However DelayEmbeddings.jl uses DynamicalSystemsBase.jl in its test suite. That creates problems when updating major versions (in fact it makes them impossible on paper).

The only way to resolve this is to not use DSB.jl in DE.jl's test. One solution is to write all trajectories needed into CSV files and save them in the main JuliaDynamics repo that holds the docs, and download them each time tests are run (we already do this for some trajectories).

@Datseris Datseris added the tests Related with the testing suite label Aug 1, 2021
@hkraemer
Copy link
Contributor

That makes sense. Also from a test-perspective, since the sensitivity to different initial conditions of chaotic time series on different machines are not easy to handle, especially when testing statistics based on relatively short time series. Let me know where exactly I should copy these trajectories and I will start incorporating these, when working on #96 and #95.

@Datseris
Copy link
Member Author

I put data I need for the org in the website repo https://github.com/JuliaDynamics/JuliaDynamics

@hkraemer
Copy link
Contributor

Then mybe lets setup a time series folder? I guess we then also have to adjust the path in the runtests.jl-file, in order to automatically download them?!

@Datseris
Copy link
Member Author

yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low priority tests Related with the testing suite
Projects
None yet
Development

No branches or pull requests

2 participants