New tests for pecuzal, uzal_cost; corrected normalization in uzal cost #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
reviewed
Aug 31, 2021
test/runtests.jl
Outdated
Comment on lines
17
to
23
| #New: | ||
| repo = "https://raw.githubusercontent.com/JuliaDynamics/JuliaDynamics/master/timeseries" | ||
| a = "test_time_series_lorenz_standard_N_10000_multivariate.csv" | ||
| download(repo*"/"*a, joinpath(tsfolder, a)) | ||
| a = "test_time_series_roessler_N_10000_multivariate.csv" | ||
| download(repo*"/"*a, joinpath(tsfolder, a)) | ||
|
|
There was a problem hiding this comment.
Should be written in terms of a loop. Define files = [all file names here] and loop over for a in files
|
hmpf, I think I PR'ed from an old branch... hm. Might not be a problem hopefully. |
|
it's okay, no conflicts. tests pass, do you need to add anything more here or the PR should be merged? |
|
no I think I'll do the loop thingy and that's it |
|
I'll fix the other two test next week or so. Super busy atm :( |
|
No problem, take your time. Don't forget that we need to tag a new release for these changes to be propagated beyond development in a stable release. You should tell me when you feel a new version should come out and I'll tag it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding #95, #96 and also #94. The correction in the computation of Uzal's cost function have been implemented and the according tests have been revised. Same holds for the brittle PECUZAL-tests. In the PECUZAL case I double-checked each test with the outcomes from my Matlab and Python implementations of the algorithm. I also relaxed the test-constraints and outsourced the time series being used (we should continuing doing this for the other methods). Hopefully this works now. Cheers