Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage metric #190

Closed
kescobo opened this issue Sep 15, 2020 · 5 comments
Closed

Add test coverage metric #190

kescobo opened this issue Sep 15, 2020 · 5 comments
Assignees

Comments

@kescobo
Copy link
Contributor

kescobo commented Sep 15, 2020

As part of JOSS review, I'm asked to assess whether you have tests. Obviously, you do, and have CI + they pass locally on my machine, which is great, but it would be nice to see what your test coverage is as it's hard for me to gauge coming to the project for the first time.

Your tests are sufficient for me to check the box on the review, this is not essential, but it would be nice. There are examples all over the place for getting this to work with travis, but let me know if you're having trouble.

@Datseris
Copy link
Member

@JonasIsensee could you please do this, while we address the remaining comments?

@JonasIsensee JonasIsensee self-assigned this Sep 16, 2020
@JonasIsensee
Copy link
Member

There is a codecov badge in the readme now.

@Datseris
Copy link
Member

oh wow 91% that's quite impressive!

@sebastianpech
Copy link
Contributor

Yeah pretty good, 100% is close 🤔. We're mostly missing warnings and errors.

@tamasgal
Copy link
Member

Oh yeah 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants