-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Makie 0.17 #99
Conversation
For whatever reason the diamond marker for discrete system doesn't exist. Also, layouting is fucked up when parameters are used
# Layout buttons | ||
controllayout[3, :][:, 1] = MakieLayout.hbox!(step, run; tellwidth = false) | ||
controllayout[3, :][:, 2] = MakieLayout.hbox!(reset, clear; tellwidth = false) | ||
controllayout[2, :] = MakieLayout.hbox!(step, run, reset, clear; tellwidth = false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was nicer to layout the buttons on the previously used 1x2 grid as before. What's the rationale to change all buttons to be in one line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it looks totally OK now. Symmetry is always nice in general. I just preferred that the step/run buttons were clearly separated from reset/clear/update buttons. Having them so close to each other and with more text on them makes it harder to separate them from each other. Doesn't matter too much in the end, probably just my personal taste, so all good.
Hm, an inspection error? Weird, I've only used what Makie provides via DataInspector. Maybe there's something messed up in the way the string for the tooltip box is created. I'll have a look. |
The issue is with Makie 0.17.7 and already being worked on. See MakieOrg/Makie.jl#2073 |
Everything is up to date. There is one place we have problem. The inspection of agents (pop ups). At the moment I get an error I am not sure how to tackle, because it doesn't come from the source of
InteractiveDynamics
. The error is:Turning
enable_inspection = false
removes the error.@fbanning do you have any idea here? You can use the Flocking example file and do
enable_inspection = true
to replicate.