Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Makie 0.17 #99

Merged
merged 12 commits into from
Jun 27, 2022
Merged

Update to Makie 0.17 #99

merged 12 commits into from
Jun 27, 2022

Conversation

Datseris
Copy link
Member

Everything is up to date. There is one place we have problem. The inspection of agents (pop ups). At the moment I get an error I am not sure how to tackle, because it doesn't come from the source of InteractiveDynamics. The error is:

ERROR: type Array has no field extents
Stacktrace:
 [1] getproperty
   @ .\Base.jl:42 [inlined]
 [2] Bbox_from_glyphcollection(text::String, gc::Vector{Point{2, Float32}})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:191
 [3] (::Makie.var"#883#886"{Observable{Any}})(gc::Vector{Point{2, Float32}}, pos::Point{2, Float32}, pad::Vec{4, Float32})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:294
 [4] #map#19
   @ C:\Users\datse\.julia\packages\Observables\ynr7h\src\Observables.jl:444 [inlined]
 [5] map(::Makie.var"#883#886"{Observable{Any}}, ::Observable{Vector{Point{2, Float32}}}, ::Observable{Any}, ::Observable{Any})
   @ Observables C:\Users\datse\.julia\packages\Observables\ynr7h\src\Observables.jl:444
 [6] plot!(plot::Combined{Makie._inspector, Tuple{Int64}})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:293

Turning enable_inspection = false removes the error.

@fbanning do you have any idea here? You can use the Flocking example file and do enable_inspection = true to replicate.

# Layout buttons
controllayout[3, :][:, 1] = MakieLayout.hbox!(step, run; tellwidth = false)
controllayout[3, :][:, 2] = MakieLayout.hbox!(reset, clear; tellwidth = false)
controllayout[2, :] = MakieLayout.hbox!(step, run, reset, clear; tellwidth = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was nicer to layout the buttons on the previously used 1x2 grid as before. What's the rationale to change all buttons to be in one line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the other two buttons also have two rows for symmetry, and now there is no gap between:

image

image

I think it looks better this way. The gap before was very large in the second case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it looks totally OK now. Symmetry is always nice in general. I just preferred that the step/run buttons were clearly separated from reset/clear/update buttons. Having them so close to each other and with more text on them makes it harder to separate them from each other. Doesn't matter too much in the end, probably just my personal taste, so all good.

@fbanning
Copy link
Member

@fbanning do you have any idea here? You can use the Flocking example file and do enable_inspection = true to replicate.

Hm, an inspection error? Weird, I've only used what Makie provides via DataInspector. Maybe there's something messed up in the way the string for the tooltip box is created. I'll have a look.

@fbanning
Copy link
Member

The issue is with Makie 0.17.7 and already being worked on. See MakieOrg/Makie.jl#2073

@Datseris Datseris merged commit 1336c78 into master Jun 27, 2022
@Datseris Datseris deleted the makie017 branch June 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants